Skip to content

DOC Add early stopping case to scoring glossary entry #30544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 30, 2024

Conversation

lucyleeow
Copy link
Member

Reference Issues/PRs

Relates to #30319 (comment)

Adds to scoring glossary entry that this parameter may also be used to specify which scoring method to use to check early stopping

What does this implement/fix? Explain your changes.

Any other comments?

cc @StefanieSenger

Copy link

github-actions bot commented Dec 27, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: d48ef4c. Link to the linter CI: here

doc/glossary.rst Outdated
* -- in some cases --, the multiple score functions to be reported,
* in a few specific cases, the score function to be used to check early
stopping, or
* for visualization related objects, the score to output or plot
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E.g., learning_curve and LearningCurveDisplay

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@lucyleeow lucyleeow added the Waiting for Second Reviewer First reviewer is done, need a second one! label Dec 30, 2024
Copy link
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR @lucyleeow!

@thomasjpfan thomasjpfan merged commit 74775ca into scikit-learn:main Dec 30, 2024
34 checks passed
@lucyleeow lucyleeow deleted the doc_gloss_scoring branch December 30, 2024 23:09
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Waiting for Second Reviewer First reviewer is done, need a second one!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants