-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC Add example links to LabelSpreading class docstring and update example headings #30553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hello @ani0075saha, thank you for your contribution. The new headings look much friendlier. Concerning the links, I would actually tend to not link the examples in Would you mind to remove the links from the docstring and only keep the rest of the PR (the headings)? That would be alright as is - or - if you like, you could also work further on improving the examples on |
@StefanieSenger Thanks for the comments. I will look at the linked good quality examples and work on improving the LabelSpreading examples. |
Hi @ani0075saha! Would you like to continue working on this PR? |
Hi @marenwestermann, it seems like I won't have the bandwidth right now to make the examples better as @StefanieSenger suggested. We can merge and close this right now with just the updated headings or someone else can continue the work. Let me know what's the best option. |
Hello @ani0075saha, that's totally fine. Then I would suggest to revert the changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the headings, @ani0075saha!
Your contribution is very welcome.
@adrinjalali, would you mind having a look?
Sorry about the long delay @StefanieSenger. Ran into some git issues today, but resolved them finally. |
@adrinjalali Can you please review and close this? Thanks! |
Reference Issues/PRs
PR to add links to the examples mentioned in issue #26927 for the semi_supervised section.
What does this implement/fix? Explain your changes.
Links to examples were added to the API docs of LabelSpreading class.
plot_label_propagation_digits_active_learning.py
example contains the functionality described inplot_label_propagation_digits.py
.So I only added links to
I also modified the example headings.
Any other comments?