Skip to content

DOC Add link to plot_lasso_and_elasticnet.py example in linear model #30587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

marouaneaka
Copy link

@marouaneaka marouaneaka commented Jan 5, 2025

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Towards 26927
Added links to lasso and elasticnet classes

Any other comments?

Copy link

github-actions bot commented Jan 5, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 645bd17. Link to the linter CI: here

Copy link
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @marouaneaka! I have a few comments:

  1. It might be helpful to include a link to the example in the ARD regression documentation as well.
  2. In the PR description, please update the text to "Towards 26927" to avoid automatically closing the meta-issue when the PR is merged.

@@ -875,6 +875,10 @@ class ElasticNet(MultiOutputMixin, RegressorMixin, LinearModel):
1.451...
>>> print(regr.predict([[0, 0]]))
[1.451...]

For an example showcasing Elastic-Net alongside Lasso and ARDRegression for sparse
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ARD regression", and likewise for Lasso.

@marouaneaka
Copy link
Author

Hi thanks for the comments : - Added link in ARD Regression, fixed typo mistake in elastic net and lasso. if there is anything else just let me know :)

Copy link
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR, @marouaneaka! I have a few more comments.

In the ARD Regression documentation, could you please move the following example:

Screenshot 2025-01-10 142444

down to where your L1 example is? After that, you can delete the "Notes" section.

@marouaneaka
Copy link
Author

Just updated ARD documentation as specified

Copy link
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the PR, @marouaneaka! Could you address the CI failure? If you click on "Details" under "scikit-learn.scikit-learn," you’ll find the error message(s).

@marenwestermann
Copy link
Member

Hi @marouaneaka! Would you like to continue working on this PR? Let us know if you need help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants