Skip to content

DOC Add missing links to Gaussian Process Classification #30605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Siddhant231xyz
Copy link

Reference Issues/PRs

#26927

What does this implement/fix? Explain your changes.

Added example plot_gpc_iris.py, plot_gpc_isoprobability.py, plot_gpc.py and plot_gpc_xor.py

Any other comments?

Copy link

github-actions bot commented Jan 7, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 860b992. Link to the linter CI: here

@StefanieSenger
Copy link
Contributor

Hi, @Siddhant231xyz,
thank you for your contribution. I would suggest to distribute the links to the sections they belong to in the user guide.

plot_gpc_iris.py, plot_gpc.py and plot_gpc_xor.py have corresponding sections there; I'm not sure about plot_gpc_isoprobability.py though.

@Siddhant231xyz
Copy link
Author

Hey @StefanieSenger,
Thank you for your response. I have made changes in my PR accordingly, please have a look and let me know if there's anything else that needs to be done.

@StefanieSenger
Copy link
Contributor

Hey @Siddhant231xyz, thanks for your adjustments.

I cannot see why you link plot_gpc_isoprobability.py at the Probabilistic predictions with GPC section, that actually display the plots from plot_gpc.py, which would be a better fit here, IMHO. If there is any reasoning that I have missed, please explain.

Please note that the links are already present in this part of the user guide, when you click on the images. In issue #30596, we are in the process to find a solution to the fact that clickability of the images is a bit hidden. So the links to the gaussian process examples might not need to be added at all. Do you have an opinion on this, @marenwestermann?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants