FIX update deprecated param for example using class_likelihood_ratios #30668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failures are related to OpenML being down. I believe the way we deal with it these weeks is to ignore these failures? |
jeremiedbb
approved these changes
Jan 20, 2025
|
I confirm running the examples locally that it fixes the warning from this particular example, so let's merge this and see whether that makes About the change in sklearn/metrics/_scorer.py this kind of hints a lack of coverage in our tests (or that this is never used not sure). |
never used indeed |
|
Oh well it looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a failure with the doc build on main that was accidentally introduced with #29288 (see comment #29288 (comment)).
Also, the PR makes
class_likelihood_ratiosuse the new param when it's indirectly used in the scoring, so that users don't get theFutureWarning, when they have no control about it.@lesteve @adrinjalali