Skip to content

DOC Fix 1.6 doc build now that OpenML is back #30716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 28, 2025
Merged

DOC Fix 1.6 doc build now that OpenML is back #30716

merged 3 commits into from
Jan 28, 2025

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Jan 25, 2025

Back-port of #30715

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 00941c7. Link to the linter CI: here

@ogrisel
Copy link
Member

ogrisel commented Jan 27, 2025

This does not work:

    ../examples/applications/plot_time_series_lagged_features.py failed leaving traceback:

    Traceback (most recent call last):
      File "/home/circleci/project/examples/applications/plot_time_series_lagged_features.py", line 42, in <module>
        bike_sharing_data_file = fetch_file(
      File "/home/circleci/project/sklearn/datasets/_base.py", line 1635, in fetch_file
        return _fetch_remote(
      File "/home/circleci/project/sklearn/datasets/_base.py", line 1525, in _fetch_remote
        raise OSError(
    OSError: The SHA256 checksum of dataset_44063.pq (328b6a6e3ceeadd368b939b50e5c4202e439e340c874a1d60ca81792c8125fca) differs from expected (d120af76829af0d256338dc6dd4be5df4fd1f35bf3a283cab66a51c1c6abd06a).

In #30715 we had to use a temporarily hosted file while waiting for the data.openml.org setup.

@lesteve
Copy link
Member Author

lesteve commented Jan 27, 2025

Yep I thought we could wait for data.openml.org to be available (I am wild-guessing this is a matter of days) before trying to backport in the release branch.

Let me know if you think there is a good reason that we want to make the 1.6.X doc build green now.

@lesteve lesteve mentioned this pull request Jan 27, 2025
Closed
@lesteve @ogrisel
Update examples/applications/plot_time_series_lagged_features.py
00941c7 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@lesteve
Copy link
Member Author

lesteve commented Jan 28, 2025 •
edited
Loading

OK we now have a good reason to want 1.6.X green, to investigate whether the rel="canonical" fix is actually working #30727.

@lesteve
Copy link
Member Author

lesteve commented Jan 28, 2025

rendered documenation looks OK, let's merge this!

@lesteve lesteve merged commit 2d1c71a into scikit-learn:1.6.X Jan 28, 2025
25 of 32 checks passed
@lesteve lesteve deleted the fast-fix-openml-1.6 branch January 28, 2025 14:19
@lesteve lesteve mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel left review comments

Assignees
No one assigned
Labels
Documentation No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lesteve @ogrisel