-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Backport docs updates (conda-forge link, canonical URL) to 1.5.x #30728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport docs updates (conda-forge link, canonical URL) to 1.5.x #30728
Conversation
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
So as feared
|
Do you know how to add just one more commit to this branch? |
I used |
I would have done the same, so seems good enough 😉. I think it's expected that the hash changes (maybe because the timestamp of the commit changes or it may even depend on the previous commit not 100% sure). The CircleCI doc build manages to build so I think this should be alright. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge this.
- this is a doc only PR and the rendered doc looks good (I checked a few pages and made sure they had all rel="canonical" and point to the stable doc
- we can ignore the Azure failures and can merge even if they are red (no required checks in release branches)
I pinged Jeremie to see if he has some insight on the cerry-picking. I'd like to avoid making future updates to 1.5.X harder because I did something weird (cherrypick). |
I am reasonably confident this is the "right way" (or at least "one right way") but let's see what he says 😉 |
Also thinking about it, I am not sure we want to back-port the improvement to the conda-forge install instructions to the Not that many people go to the old versions doc pages (old means <= 1.5 at the time of writing since latest release is 1.6), and hopefully the |
That's how we proceed usually. It's expected that the hash changes, don't worry :) |
Now that it's there it's less effort to keep it. I let you decide :) |
OK let's merge this then! Thanks @jeremiedbb for the reassurance 😉 |
To make sure this gets deployed to 1.5.X branch we want to make sure this build is green 🤞 |
The build was green and Now we just have to wait and see whether that actually fixes the root issue, but I am somewhat optimistic 💪 |
I followed the first step from https://scikit-learn.org/dev/developers/maintainer.html#reference-steps (create a new branch from main, then rebase from
upstream/1.5.x
).I picked two commits. The first one updates the conda-forge install page we link to, the second one adds teh canonical URL to our docs pages. Need to check if we need the conda-forge change/if it makes sense.
xref #30727