MNT Use regression data for check_sample_weight_invariance test on multioutput regression metrics
#30829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Ref: #30787 (comment)
What does this implement/fix? Explain your changes.
test_multilabel_sample_weight_invarianceused classification data forMULTIOUTPUT_METRICS.Created a new test
test_multioutput_sample_weight_invarianceforMULTIOUTPUT_METRICS.As "multilabel" does not accurately describe multioutput regression tasks, I didn't want to have this test under
test_multilabel...Any other comments?
I thought about changing the name to
MULTIOUTPUT_REGRESSION_METRICSas we do use the term "Multiclass-multioutput" for classification (https://scikit-learn.org/dev/modules/multiclass.html#multiclass-and-multioutput-algorithms) BUT AFAICT we don't have any metrics that support "Multiclass-multioutput". WDYT @ogrisel ?