TST Use global_random_seed in test_huber.py #30912
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also added an empty commit to trigger all builds. |
Rishab260
suggested changes
Mar 3, 2025
There was a problem hiding this comment.
Hi @ArturoSbr, I think your empty commit should look like this
test_huber [all random seeds]
make_regression_with_outliers
test_huber_equals_lr_for_high_epsilon
test_huber_max_iter
test_huber_gradient
test_huber_sample_weights
test_huber_sparse
test_huber_scaling_invariant
test_huber_and_sgd_same_results
test_huber_warm_start
test_huber_better_r2_score
test_huber_bool
For reference:
<title> [all random seeds]
<test_name_1>
<test_name_2>
...
- test_huber [all random seeds] - make_regression_with_outliers - test_huber_equals_lr_for_high_epsilon - test_huber_max_iter - test_huber_gradient - test_huber_sample_weights - test_huber_sparse - test_huber_scaling_invariant - test_huber_and_sgd_same_results - test_huber_warm_start - test_huber_better_r2_score - test_huber_bool
|
Hi @Rishab260! Does this PR need any additional changes? |
Hi @ArturoSbr , I can see that this has 7 tests failing. You might want to look into why these tests have failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the file
sklearn/linear_model/tests/test_huber.pyby replacing all instances of hardcoded random seeds (ierandom_state=0) withglobal_random_seed(in accordance to this issue).