-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC: added link to cluster_plot_coin_ward_segmentation example in feature_extraction.grid_to_graph #30916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: added link to cluster_plot_coin_ward_segmentation example in feature_extraction.grid_to_graph #30916
Conversation
Hi @mahmadza, thanks a lot for your PR! While checking this, I found there is a pretty nice explanation already in https://scikit-learn.org/stable/modules/feature_extraction.html#connectivity-graph-of-an-image What would you think of instead of adding a link to the example on the docstring of the function, to add a link to this part of the user guide? I think it would be more informative and we have the example used as a demonstration in there. It could be done similarily as in PR #30666. |
@StefanieSenger , |
Hi @mahmadza, sorry I think I did not express myself clearly before. I will try again: What do you think about not linking the example, but instead linking to the user guide where the example is treated. This link could be in the same spot as you had added the original link (docstring of grid_to_graph). I think it's even better than the direct to the example itself, because this part of the user guide treats the example and adds context to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work, @mahmadza! I appreciate that.
This PR looks very good and I would think it is ready to merge.
Would you check, @adrinjalali ?
That's a very nice catch @StefanieSenger ! |
Reference Issues/PRs
Towards #30621
What does this implement/fix? Explain your changes.
Added a link to an example of structured Ward hierarchical clustering on an image of coins in
feature_extraction.grid_to_graph
method.