Skip to content

TST: force dtype of arange to int64 to not be platform dependent #30948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

TST: force dtype of arange to int64 to not be platform dependent #30948

merged 1 commit into from
Mar 13, 2025

Conversation

AndresGuzman-Ballen
Copy link
Contributor

@AndresGuzman-Ballen AndresGuzman-Ballen commented Mar 5, 2025 •
edited by thomasjpfan
Loading

Reference Issues/PRs

Fixes #30782, specifically applying the suggestion that @glemaitre had made here: #30782 (comment)

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 7305113. Link to the linter CI: here

@AndresGuzman-Ballen AndresGuzman-Ballen mentioned this pull request Mar 5, 2025
Closed
glemaitre
glemaitre approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AndresGuzman-Ballen LGTM.

glemaitre
glemaitre requested changes Mar 5, 2025
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. I actually said something wrong ;). We should match the dtype of the signature. Not sure why I wrote np.float64.

@AndresGuzman-Ballen
Copy link
Contributor Author

Anything else that's needed before this can be merged?

glemaitre
glemaitre approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @AndresGuzman-Ballen

@lesteve do you want to have another look.

thomasjpfan
thomasjpfan approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @AndresGuzman-Ballen ! LGTM

@thomasjpfan thomasjpfan merged commit cd3cdff into scikit-learn:main Mar 13, 2025
37 of 38 checks passed
@AndresGuzman-Ballen
Copy link
Contributor Author

Great! Always happy to contribute to open-source. All I need is for @glemaitre to give me diffs and I'll do the rest ;)

@AndresGuzman-Ballen AndresGuzman-Ballen deleted the gh-30782 branch March 13, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
module:tree No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_py_sort() returns ValueError on windows with numpy 1.26.4 but works correctly with numpy 2.x
3 participants
@AndresGuzman-Ballen @thomasjpfan @glemaitre