Added link to plot_grid_search_text_feature_extraction.py under TfidfVectorizer #30974
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanieSenger
approved these changes
Mar 14, 2025
There was a problem hiding this comment.
Thanks for your contribution, @AnthonyPrudent! It looks all good to me and I think it can be merged.
Apart from this PR, I am not so happy about the enumeration-like listing of links to examples in the TFIDF docstring, but that's a problem that was existing before.
Maybe a follow up task could be to mention these in the :ref:User Guide <text_feature_extraction> section of the User Guide instead of here. I would suggest to open an issue with a label for moderate difficulty for this, since this requires some more understanding of the topic.
What do you think, @adrinjalali?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #30621
What does this implement/fix? Explain your changes.
Added a link to plot_grid_search_text_feature_extraction.py in the API documentation under TfidfVectorizer.
Any other comments?