-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC: add link to example plot_digits_agglomeration.py #30979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
doc/modules/clustering.rst
Outdated
|
||
* :ref:`sphx_glr_auto_examples_cluster_plot_digits_agglomeration.py`: This | ||
example shows how similar features are merged together using feature | ||
agglomeration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agglomeration | |
agglomeration. | |
I think this shall fix the linting issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AshleyNDoerfler, thanks for your PR.
We need to fix the linting issues.
Hi @StefanieSenger, I added the period and committed it. I believe it should be good to go. |
|
||
* :ref:`sphx_glr_auto_examples_cluster_plot_digits_agglomeration.py`: This | ||
example shows how similar features are merged together using feature | ||
agglomeration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agglomeration. | |
agglomeration. | |
You also need to add an empty line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Stefanie, I am trying the add the empty line, but it fails "Trim trailing white spaces" when I try to commit the change. Do you know what's causing this issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's pre-commit in action. Please google how pre-commit works: you need to add the changed files and commit again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or you can commit my suggestion in the changed files part of this PR.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
An example for plot_digits_agglomeration.py was missing in the clustering documentation, so I added it into clustering.rst under the feature agglomeration section.
Any other comments?