Skip to content

DOC: add link to example plot_digits_agglomeration.py #30979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AshleyNDoerfler
Copy link

Reference Issues/PRs

What does this implement/fix? Explain your changes.

An example for plot_digits_agglomeration.py was missing in the clustering documentation, so I added it into clustering.rst under the feature agglomeration section.

Any other comments?

Copy link

github-actions bot commented Mar 12, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 3e85c0f. Link to the linter CI: here


* :ref:`sphx_glr_auto_examples_cluster_plot_digits_agglomeration.py`: This
example shows how similar features are merged together using feature
agglomeration
Copy link
Contributor

@StefanieSenger StefanieSenger Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
agglomeration
agglomeration.

I think this shall fix the linting issue.

Copy link
Contributor

@StefanieSenger StefanieSenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AshleyNDoerfler, thanks for your PR.

We need to fix the linting issues.

@AshleyNDoerfler
Copy link
Author

Hi @StefanieSenger, I added the period and committed it. I believe it should be good to go.


* :ref:`sphx_glr_auto_examples_cluster_plot_digits_agglomeration.py`: This
example shows how similar features are merged together using feature
agglomeration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
agglomeration.
agglomeration.

You also need to add an empty line.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Stefanie, I am trying the add the empty line, but it fails "Trim trailing white spaces" when I try to commit the change. Do you know what's causing this issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's pre-commit in action. Please google how pre-commit works: you need to add the changed files and commit again.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or you can commit my suggestion in the changed files part of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants