Skip to content

MNT Update mypy #31018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2025
Merged

MNT Update mypy #31018

merged 3 commits into from
Mar 22, 2025

Conversation

DimitriPapadopoulos
Copy link
Contributor

Reference Issues/PRs

See also #30976.

What does this implement/fix? Explain your changes.

Update mypy.

Any other comments?

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 18, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5c69fac. Link to the linter CI: here

@DimitriPapadopoulos
MNT Fix mypy error
b4e15bf 
error: Unsupported operand types for + [operator]
@DimitriPapadopoulos
MNT Fix mypy note
5c69fac 
note: By default the bodies of untyped functions are not checked,
      consider using --check-untyped-defs  [annotation-unchecked]
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review March 20, 2025 08:09
@adrinjalali adrinjalali enabled auto-merge (squash) March 22, 2025 09:09
@adrinjalali adrinjalali merged commit fbd3a04 into scikit-learn:main Mar 22, 2025
36 of 37 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the mypy branch March 22, 2025 13:55
lucyleeow pushed a commit to lucyleeow/scikit-learn that referenced this pull request Apr 2, 2025
@DimitriPapadopoulos @lucyleeow
MNT Update mypy (scikit-learn#31018)
2026afc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @adrinjalali