-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
DOC Update plots in Categorical Feature Support in GBDT example #31062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
78409cb
DOC Update plots in plot_gradient_boosting_categorical
85a9ffb
Display pipelines and wording tweak
71a19b9
Merge main
07c9764
Add arrow and denser ticks as per Olivier's suggestion
c9771b9
Avoid override of previous results
a201d7d
Merge main
f210c2d
Simplify code
1458d42
Update examples/ensemble/plot_gradient_boosting_categorical.py
ArturoAmorQ 10b4a04
Address Lucy's comments
4d48f5d
Apply suggestions from code review
23be2cc
Mention that error bars correspond to 1 std
272ea7f
Merge branch 'main' into change_plots
ArturoAmorQ 96b7c7c
Add explanation on 'best models'
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, the last graph, it is a bit tricky to quickly tell the native and ordinal markers/error bars
Would it be 'easy' to change the colour of the the marker, to be the same colour as the scatter points?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that risks leading the reader to think that the marker is an actual scatter point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point.
Stupid question, for 'Ordinal', why is the black error bar (?) marker not centered between the horizontal and vertical error bars?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, I see that it is in the new rendered doc, for some reason the horizontal error bar was not rendering properly in the first one above