Skip to content

MNT Apply ruff/flake8-executable rules (EXE) #31063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

MNT Apply ruff/flake8-executable rules (EXE) #31063

merged 2 commits into from
Apr 30, 2025

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Mar 24, 2025 •
edited
Loading

What does this implement/fix? Explain your changes.

Consistency between file modes and shebangs. Run chmod +x and chmod -x.

Any other comments?

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 24, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 758cab7. Link to the linter CI: here

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft March 24, 2025 16:07
@DimitriPapadopoulos
MNT Apply ruff/flake8-executable rule EXE001
8d35a56 
EXE001 Shebang is present but file is not executable

Run `chmod +x`.
@DimitriPapadopoulos
MNT Apply ruff/flake8-executable rule EXE002
758cab7 
EXE002 The file is executable but no shebang is present

Run `chmod -x`.
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review March 24, 2025 16:24
@adrinjalali adrinjalali enabled auto-merge (squash) April 30, 2025 13:03
@adrinjalali adrinjalali merged commit d042d68 into scikit-learn:main Apr 30, 2025
37 of 38 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the EXE branch April 30, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
module:cluster module:ensemble No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @adrinjalali