Skip to content

Fix PandasAdapter causes crash or misattributed features #31079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix PandasAdapter causes crash or misattributed features #31079

wants to merge 2 commits into from

Conversation

nicolas-bolle
Copy link

Reference Issues/PRs

Fixes #31051. See also #28731.

What does this implement/fix? Explain your changes.

Any other comments?

  • Added a unit test for the "series" case
  • Made the unit test index different from the default index, since the issue doesn't happen when using default indexes

@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 14b55ef. Link to the linter CI: here

@nicolas-bolle nicolas-bolle mentioned this pull request Apr 10, 2025
Open
@lorentzenchr lorentzenchr requested a review from glemaitre April 14, 2025 11:07
@nicolas-bolle
Copy link
Author

@glemaitre wondering if I can get a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre Awaiting requested review from glemaitre

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
module:utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PandasAdapter causes crash or misattributed features
1 participant
@nicolas-bolle