Skip to content

MNT Make name spelling uniform in changelogs #31116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025

Conversation

glevv
Copy link
Contributor

@glevv glevv commented Mar 31, 2025

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This PR unifies all the different name spellings of my name, surname and nickname into one.

Any other comments?

I'm not sure if this one is allowed, but I really hope so.

@glevv
Copy link
Contributor Author

glevv commented Mar 31, 2025

Can someone please tell me if this is allowed?

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: f918def. Link to the linter CI: here

@lesteve
Copy link
Member

lesteve commented Mar 31, 2025

This seems fine to do this change.

I think part of the content (the contributor names for each release) is automatically generated from your git commit message info though. So if you haven't done so you probably want to double-check that git config user.name returns the spelling you want.

@glevv
Copy link
Contributor Author

glevv commented Mar 31, 2025

This seems fine to do this change.

I think part of the content (the contributor names for each release) is automatically generated from your git commit message info though. So if you haven't done so you probably want to double-check that git config user.name returns the spelling you want.

Yes, I only saw it recently that my git config was out of date and I changed it.
There were a bunch of PRs from me from different computers over the years, so the history of my contributions still needs to be changed.
I think this one should be without changelog entry?

@lesteve
Copy link
Member

lesteve commented Mar 31, 2025

I think this one should be without changelog entry?

No need for a changelog for this PR indeed.

@glevv glevv marked this pull request as ready for review March 31, 2025 15:11
@lesteve lesteve changed the title MAINT Change of name in changelogs MNT Change of name in changelogs Mar 31, 2025
@lesteve lesteve changed the title MNT Change of name in changelogs MNT Make name spelling uniform in changelogs Mar 31, 2025
@lesteve lesteve merged commit ecef0bc into scikit-learn:main Mar 31, 2025
38 checks passed
@lesteve
Copy link
Member

lesteve commented Mar 31, 2025

Merging this one!

lucyleeow pushed a commit to lucyleeow/scikit-learn that referenced this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants