-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC add link to plot_gpr_on_structured_data example in gaussian_process #31150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ashbleu,
thank you for opening this PR.
You have identified that this example is hard to discover (currently there is no link to it anywhere in the docs).
Instead of adding the link as a 5th link line in Examples, I would suggest to instead integrate it in the section about kernels in the user guide, here: https://scikit-learn.org/stable/modules/gaussian_process.html#gp-kernels.
- as a sentence
- pointing out the example's demonstration on how to design a custom kernel for discrete data
Would you mind going back to make this change?
Hi @StefanieSenger, I have added a sentence about the example in the Kernels section, and removed it from the list of links in Examples. Please let me know if you have any other suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work, @ashbleu!
That looks very good. The sentence is in the right spot I would think and everything renders correctly. The CI failures are just http request errors and should go away if you re-trigger the CI by pushing an empty commit.
Would you like to take a look at this PR, @adrinjalali ?
Reference Issues/PRs
Towards #30621.
What does this implement/fix? Explain your changes.
Added link to the
plot_gpr_on_structured_data
example in the Gaussian Process Regression section ofgaussian_process
in the User Guide, since it isn't currently linked anywhere on that page.Any other comments?