Skip to content

MNT Clean-up deprecations for 1.7: Remainder column type of ColumnTransformer #31167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

MNT Clean-up deprecations for 1.7: Remainder column type of ColumnTransformer #31167

wants to merge 2 commits into from
+62 −208

Conversation

jeremiedbb
Copy link
Member

  • Made the new behavior the default, i.e. try to match the type of the other columns for the remainder column.
  • Removed the old behavior. The force_int_remainder_cols parameter has no effect anymore. I think this is okay since it was available for 2 releases with a future warning.
  • Deprecated the force_int_remainder_cols param, to be removed in 1.9.

@jeremiedbb jeremiedbb added this to the 1.7 milestone Apr 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 3293439. Link to the linter CI: here

@adrinjalali adrinjalali added Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one! labels Apr 30, 2025
lucyleeow
lucyleeow approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

doc/whats_new/upcoming_changes/sklearn.compose/31167.api.rst
@@ -0,0 +1,4 @@
The `force_int_remainder_cols` parameter of :class:`compose.ColumnTransformer` and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be in bullet form?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@lucyleeow lucyleeow lucyleeow approved these changes

Assignees
No one assigned
Labels
module:compose Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one!
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremiedbb @adrinjalali @lucyleeow