✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: fb793c4. Link to the linter CI: here}

I just realized that _pairwise_callable actually calls check_pairwise_array, so it is done for callables as well. It's just that we don't force 2D arrays here to allow things like distances between strings.

Yup I just said dim checking, it doesn't enforce 2d or check x and y have the same 2nd dim.

Do you think comment is not needed?

It is essentially the same comment as:

but I thought it would be useful to have it in pairwise_distances, especially as we don't mention this in the docstring.

I'm okay with the comment but I feel that it should instead be in _pairwise_callable right before the call to check_pairwise_arrays, otherwise we don't really understand what it refers to.

That's a good point because this is relevant to both pairwise_kernels and pairwise_distances when metric is a callable. Will move comment to where you suggest.

What do you think about including in the 'Notes' section of both functions, that no restrictions are placed on X and Y dimensions when metric is a callable. I think the original confusion for me was because both functions docstrings specify clearly what dimensions X and Y should be, but does not mention that this does not apply when metric is a callable.

What do you think about including in the 'Notes' section of both functions, that no restrictions are placed on X and Y dimensions when metric is a callable. I think the original confusion for me was because both functions docstrings specify clearly what dimensions X and Y should be, but does not mention that this does not apply when metric is a callable.

looks good

Thanks @jeremiedbb ! Done.