DOC Add note about using _get_namespace_device_dtype_ids
#31180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Apr 11, 2025
|
Opened #31192, closing this one |
|
Re-opening this after #31192 turned out to be too difficult. cc @lesteve and @thomasjpfan :D |
thomasjpfan
approved these changes
Apr 23, 2025
ogrisel
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow up to #31074
Adds comment in
yield_namespace_device_dtype_combinationsdocstring to remind people to use_get_namespace_device_dtype_idscc @lesteve
What does this implement/fix? Explain your changes.
Any other comments?