TST Use global_random_seed in sklearn/datasets/tests/test_samples_generator.py #31181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_make_regression test_make_regression_multitarget test_make_blobs test_make_blobs_n_samples_list_with_centers test_make_friedman1 test_make_friedman2 test_make_friedman3 test_make_sparse_coded_signal test_make_spd_matrix test_make_swiss_roll test_make_s_curve test_make_moons
jeremiedbb
approved these changes
Apr 11, 2025
There was a problem hiding this comment.
LGTM. Thanks @DeaMariaLeon
The other tests with randomness that were not updated to use global_random_seed don't test mathematical properties, just shapes and errors and stuff like that, so I'm fine with the list of updated tests.
| X, y, c = make_regression( | ||
| n_samples=100, | ||
| n_samples=200, |
There was a problem hiding this comment.
I think it's okay to increase the size of the dataset here since we're testing the variance of the generated data, and so we need sufficient data points for it to be stable enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #22827
What does this implement/fix? Explain your changes.
Adds global random seeds to some tests
Any other comments?
cc @glemaitre