Skip to content

DOC Scale data before using k-neighbours regression (fixes #31200) #31201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

DOC Scale data before using k-neighbours regression (fixes #31200) #31201

wants to merge 4 commits into from
+35 −22

Conversation

5nizza
Copy link

@5nizza 5nizza commented Apr 14, 2025 •
edited
Loading

Fixes #31200
by basically replacing
KNeigboursRegressor(......) with make_pipeline(StandardScaler(), KNeigboursRegressor(......))

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 14, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: b7ebbbd. Link to the linter CI: here

ogrisel
ogrisel reviewed Apr 24, 2025
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Since we now use custom estimator names, let's not use class names anymore.

Also, could you please fix the linting problems (use the formatters) as instructed in the automated comment above?

@5nizza @ogrisel
Apply suggestions from code review (next: resolving lint issues)
ee09627 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@ArturoAmorQ ArturoAmorQ changed the title scaling data before using k-neighbours regression (fixes #31200) DOC Scale data before using k-neighbours regression (fixes #31200) Apr 24, 2025
ArturoAmorQ
ArturoAmorQ reviewed Apr 28, 2025
View reviewed changes
Copy link
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @5nizza. These suggestions should fix the failing CI, but I strongly recommend using pre-commit to format your files before commiting:

conda install pre-commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel left review comments

@ArturoAmorQ ArturoAmorQ ArturoAmorQ left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOC Examples (imputation): add scaling when using k-neighbours imputation
3 participants
@5nizza @ogrisel @ArturoAmorQ