Skip to content

TST Use global_random_seed in sklearn/decomposition/tests/test_fastica.py #31203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025

Conversation

DeaMariaLeon
Copy link
Contributor

@DeaMariaLeon DeaMariaLeon commented Apr 14, 2025

Reference Issues/PRs

Towards #22827

What does this implement/fix? Explain your changes.

Adds global random seeds to some tests

Any other comments?

cc @glemaitre

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 6fb71f8. Link to the linter CI: here

@DeaMariaLeon DeaMariaLeon changed the title TestsTST Use global_random_seed in sklearn/decomposition/tests/test_fastica.py TST Use global_random_seed in sklearn/decomposition/tests/test_fastica.py Apr 14, 2025
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@jeremiedbb jeremiedbb merged commit cd119bb into scikit-learn:main Apr 15, 2025
42 of 43 checks passed
@DeaMariaLeon DeaMariaLeon deleted the tests branch April 15, 2025 14:58
lucyleeow pushed a commit to EmilyXinyi/scikit-learn that referenced this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants