MNT Avoid nested sequence in weighted_percentile
#31211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
approved these changes
Apr 18, 2025
jeremiedbb
approved these changes
Apr 18, 2025
|
Yes, the previous version will fail once data-apis/array-api-strict#147 is in released version (I tested all array-api tests in sklearn with that array-api-strict PR, and this was the only failure) |
|
@jeremiedbb are you happy for this to go in? |
|
I merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Use
xp.stackinstead ofxp.asarraywith a nested sequence of arrays - see data-apis/array-api-strict#147 - inweighted_percentileI think this still gives the correct dtype and device of the output.
What does this implement/fix? Explain your changes.
Any other comments?
cc @ev-br and @ogrisel @betatim who reviewed the original PR