MNT Enforce ruff/pygrep-hooks rules (PGH) #31226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use specific rule codes when using `noqa`
ce4c66f to
33934dd
Compare
52c2606 to
0410534
Compare
Use specific rule codes when ignoring type issues
Import block is un-sorted or un-formatted
f-string without any placeholders
0410534 to
c202eca
Compare
adrinjalali
approved these changes
Apr 28, 2025
DimitriPapadopoulos
added a commit
to DimitriPapadopoulos/scikit-learn
that referenced
this pull request
Apr 28, 2025
adrinjalali
pushed a commit
that referenced
this pull request
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Use specific rule codes when ignoring type issues and
noqa.Any other comments?
Also fix a few issues surfacing after removing blanket
noqa.