Skip to content

MNT Clean-up deprecations for 1.7: byte labels #31236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

MNT Clean-up deprecations for 1.7: byte labels #31236

merged 1 commit into from
Apr 24, 2025

Conversation

jeremiedbb
Copy link
Member

type_of_target now errors when labels are in byte format.

@jeremiedbb jeremiedbb added No Changelog Needed Quick Review For PRs that are quick to review labels Apr 21, 2025
@jeremiedbb jeremiedbb added this to the 1.7 milestone Apr 21, 2025
@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 0598446. Link to the linter CI: here

virchan
virchan approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR @jeremiedbb!

@jeremiedbb jeremiedbb merged commit eb40a5f into scikit-learn:main Apr 24, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@virchan virchan virchan approved these changes

Assignees
No one assigned
Labels
module:metrics module:utils No Changelog Needed Quick Review For PRs that are quick to review
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremiedbb @thomasjpfan @virchan