Investigate test_precomputed_nearest_neighbors_filtering[60] failure on CI
#31262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_precomputed_nearest_neighbors_filtering
|
Ok, so this test is definitely platform sensitive. |
|
I can also reproduce the failure on arm64 macOS with if I use openblas instead of accelerate in my dev env: |
…zure parallel] [all random seeds] test_precomputed_nearest_neighbors_filtering
…graph [azure parallel] [all random seeds] test_precomputed_nearest_neighbors_filtering
|
I am not 100% sure, but I think the previous way the test was written could lead to tied neighbors. Adding a 3rd data dimension and using the continuous valued distance graph instead of the discretized connectivity graph reduces this likelihood and makes the tests robust, even with the original small dataset size. |
adrinjalali
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to reproduce #31256 on the CI.