Fix default value of average in precision_recall_fscore_support #31270
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original aim might be the opposite to this commit, leaving it as it was(None), and changing the documentation. However, the fact that the original documentation explicitly mentions 'binary' for that value led me to make this decision
adrinjalali
reviewed
Apr 30, 2025
| average=None, | ||
| average="binary", |
There was a problem hiding this comment.
I think the documentation should follow the code, not the other way around. Changing this would change existing code behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
None. This is a very trivial issue
What does this implement/fix? Explain your changes.
precision_recall_fscore_supporthas a parameter calledaverage, and it is documented to bebinaryby default. However, it is actually coded to beNone, and this mismatch causes an unexpected behaviour.Any other comments?
The original aim might be the opposite to this commit, leaving it as it was(
None), and changing the documentation. However, the fact that the original documentation explicitly mentions'binary'for that value led me to make this decision