Skip to content

Fix default value of average in precision_recall_fscore_support #31270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sklearn/metrics/_classification.py
Original file line number Diff line number Diff line change
Expand Up @@ -1793,7 +1793,7 @@ def precision_recall_fscore_support(
beta=1.0,
labels=None,
pos_label=1,
average=None,
average="binary",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the documentation should follow the code, not the other way around. Changing this would change existing code behavior.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the documentation instead, and returned the code

warn_for=("precision", "recall", "f-score"),
sample_weight=None,
zero_division="warn",
Expand Down Expand Up @@ -1858,7 +1858,7 @@ def precision_recall_fscore_support(
`average != 'binary'` to report metrics for one label only.

average : {'micro', 'macro', 'samples', 'weighted', 'binary'} or None, \
default='binary'
default=None
This parameter is required for multiclass/multilabel targets.
If ``None``, the metrics for each class are returned. Otherwise, this
determines the type of averaging performed on the data:
Expand Down
Loading