Skip to content

Fix internal kwargs leakage in scorers (metrics._scorer) #31293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
+9 −1
Open

Fix internal kwargs leakage in scorers (metrics._scorer) #31293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
61b9e1f
Replace filtered data fixture with synthetic binary dataset
NEREUScode Apr 25, 2025
e299bf6
Update test_roc_curve_display.py
NEREUScode Apr 25, 2025
7ab9430
Update test_roc_curve_display.py
NEREUScode Apr 25, 2025
4cfe688
Replace filtered data fixture with synthetic binary dataset
NEREUScode Apr 25, 2025
e8b1e45
update the data_binary and delete the data()
NEREUScode Apr 28, 2025
57bc822
Merge branch 'main' into main
NEREUScode Apr 28, 2025
b845dcf
fix the importation
NEREUScode Apr 28, 2025
3d086a2
Merge branch 'main' of github.com:NEREUScode/scikit-learn
NEREUScode Apr 28, 2025
d90e108
Merge branch 'main' into main
NEREUScode Apr 29, 2025
90077ae
Merge branch 'main' into main
NEREUScode Apr 29, 2025
25b8e5a
Prevent internal kwargs from leaking to user scoring functions(metrics)
NEREUScode May 1, 2025
11e8db8
Merge branch 'main' of github.com:NEREUScode/scikit-learn
NEREUScode May 1, 2025
7816cea
Merge branch 'main' into main
NEREUScode May 1, 2025
5a211b6
fix the ruff format
NEREUScode May 1, 2025
4bb8f21
Merge branch 'main' of github.com:NEREUScode/scikit-learn
NEREUScode May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ _configtest.o.d

# virtualenv from advanced installation guide
sklearn-env/
sklenv/

# Default JupyterLite content
jupyterlite_contents
Expand Down
9 changes: 8 additions & 1 deletion sklearn/metrics/_scorer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,14 @@ def _score(self, method_caller, estimator, X, y_true, **kwargs):
)

scoring_kwargs = {**self._kwargs, **kwargs}
return self._sign * self._score_func(y_true, y_pred, **scoring_kwargs)
# Filter out internal control parameters before passing to user function
filtered_kwargs = {
k: v
for k, v in scoring_kwargs.items()
if k not in {"needs_sample_weight", "response_method"}
}

return self._sign * self._score_func(y_true, y_pred, **filtered_kwargs)


@validate_params(
Expand Down