TST Added global_random_seed to test functions #31317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sklearn/ensemble/_hist_gradient_boosting/tests/test_binning.py instead of 42
sklearn/ensemble/_hist_gradient_boosting/tests/test_compare_lightgbm.py, however all tests for global_random_seed were skipped by the command : SKLEARN_TESTS_GLOBAL_RANDOM_SEED="all" pytest sklearn/ensemble/_hist_gradient_boosting/tests/test_compare_lightgbm.py -k test_some_function
sklearn/ensemble/_hist_gradient_boosting/tests/test_gradient_boosting.py tests; all changed functions passed all tests, the functions, where adding global_random_seed couldn't pass the tests, were not changed
sklearn/ensemble/_hist_gradient_boosting/tests/test_grower.py, all changed functions passed all tests.
sklearn/ensemble/_hist_gradient_boosting/tests/test_histogram.py. all changed functions pass all tests.
sklearn/ensemble/_hist_gradient_boosting/tests/test_monotonic_constraints.py, all functions with global_random_seed pass all tests
sklearn/ensemble/_hist_gradient_boosting/tests/test_splitting.py, all changed functions pass all tests
test_split_interaction_constraints in sklearn/ensemble/_hist_gradient_boosting/tests/test_splitting.py, all tests passed
sklearn/ensemble/_hist_gradient_boosting/tests/test_warm_start.py, all tests passed for the changed function (test_random_seeds_warm_start)
|
@HakimTaoufik Thanks for this PR and your motivation to contribute.
I guess it's a good idea to follow this advice. Please open a new PR with just one test file modified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I picked up on the Issue #22827 and added global_random_seed to functions that use RandomState.
All my changes were in the sklearn/ensemble/_hist_gradient_boosting/tests/ directory/
Most of the functions were changed to add the global_random_seed, but some produced errors when changing so I kept them as they were.
All the tests passed after the changes and now the following python files are cleared from the issue :