-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC Add "see also" section to learning_curve docstring #31321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chemousesi
wants to merge
2
commits into
scikit-learn:main
Choose a base branch
from
chemousesi:set-see-also-learning-curve
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
DOC Add "see also" section to learning_curve docstring #31321
chemousesi
wants to merge
2
commits into
scikit-learn:main
from
chemousesi:set-see-also-learning-curve
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturoAmorQ
approved these changes
May 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @chemousesi! This should fix the failing CI, but I also suggest a wording tweak.
Comment on lines
+1932
to
+1937
See also: | ||
-------- | ||
LearningCurveDisplay.from_estimator : Create a learning curve | ||
display from an estimator | ||
|
||
LearningCurveDisplay.from_model : Learn Curve visualization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LearningCurveDisplay.from_model doesn't exit
Suggested change
See also: | |
-------- | |
LearningCurveDisplay.from_estimator : Create a learning curve | |
display from an estimator | |
LearningCurveDisplay.from_model : Learn Curve visualization | |
See also | |
-------- | |
LearningCurveDisplay.from_estimator : Plot a learning curve using an | |
estimator and data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Somewhat related to #31302
What does this implement/fix? Explain your changes.
This PR adds a cross-reference in the
learning_curve
docstring toLearningCurveDisplay.from_estimator
Any other comments?
done during the probabl unaite workshop