-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
Release 1.7.0rc1 #31335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.7.0rc1 #31335
Conversation
pyproject.toml
Outdated
build-backend = "mesonpy" | ||
# Minimum requirements for the build system to execute. | ||
requires = [ | ||
"meson-python>=0.16.0", | ||
"Cython>=3.0.10", | ||
"numpy>=2", | ||
"scipy>=1.8.0", | ||
"meson-python>=0.16.0,<0.19.0", | ||
"Cython>=3.0.10,<3.0.13", | ||
"numpy>=2,<2.3.0", | ||
"scipy>=1.8.0,<1.16.0", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upper bound the build dependencies in release branch. See discussions in #31183
I used the same policy as scipy, i.e upper bound to the last major/minor release at the time (allow future bug-fix releases).
cc/ @thomasjpfan @ogrisel @glemaitre @lesteve @betatim @adrinjalali
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with using the SciPy approach. (We'll need to add this policy to the release checklist)
Given this is a build dependency in pyproject.toml
, distro packages can still choose to ignore them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the cython upper bound in 9f3dd26, because I previously used a x.y.z version, not following the policy I just mentioned...
(We'll need to add this policy to the release checklist)
I'll make a PR to main when the rc is out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I had to modify the cython upper bound again because we need a pre-release for free-threading for now.
The current official releease is 3.0.12
so the upper bound should be 3.1.0
.
But free-threading support is only available in 3.1.Zrc1
, so I set the upper bound to 3.2.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the nightly builds are now green with 3.1.0rc1, I think it's fine.
Looks like there's an issue with free-threading. Are you aware of this @lesteve ? |
Free-threaded started to fail this morning. |
The free-threaded issue seems to have gone away for some reason, maybe a change in the runners image? I think this happened when For completeness I can reproduce the error locally with a vanilla Python 3.13 and setting
|
[cd build]
commit message to upload wheels to the staging repoand wait for merge