DOC Remove old section _fit_and_score_over_thresholds
#31339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyTedde
reviewed
May 8, 2025
There was a problem hiding this comment.
Hi @lucyleeow,
I've reviewed this PR. Maybe a dumb question, but has score_method ever been committed before, or was the reference in the docstring added in anticipation of a hypothetical feature that was never implemented? (Just trying to understand the context.) Thanks!
ogrisel
approved these changes
May 9, 2025
|
@AnthonyTedde The feature was implemented in a first version of More details in the discussion of the original PR: #26120 (review) |
lorentzenchr
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
As discussed with @glemaitre this part was dropped during implementation, so removing this from the docs.
What does this implement/fix? Explain your changes.
Any other comments?