Skip to content

BLD Add missing cython generator for a few extensions #31346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

BLD Add missing cython generator for a few extensions #31346

merged 2 commits into from
May 9, 2025

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented May 9, 2025 •
edited
Loading

Follow-up of #31212 noticed in #31342.

I found all of them through the following git grep. The remaining matches are custom_target:

❯ git grep '\.pyx' -- **/meson.build | grep -v process | grep -P '\w+\.pyx'
sklearn/_loss/meson.build:  output: '_loss.pyx',
sklearn/_loss/meson.build:  input: '_loss.pyx.tp',
sklearn/metrics/_pairwise_distances_reduction/meson.build:  output: '_datasets_pair.pyx',
sklearn/metrics/_pairwise_distances_reduction/meson.build:  input: '_datasets_pair.pyx.tp',
sklearn/metrics/_pairwise_distances_reduction/meson.build:  output: '_base.pyx',
sklearn/metrics/_pairwise_distances_reduction/meson.build:  input: '_base.pyx.tp',
sklearn/metrics/_pairwise_distances_reduction/meson.build:  output: '_middle_term_computer.pyx',
sklearn/metrics/_pairwise_distances_reduction/meson.build:  input: '_middle_term_computer.pyx.tp',
sklearn/metrics/_pairwise_distances_reduction/meson.build:    output: '_argkmin.pyx',
sklearn/metrics/_pairwise_distances_reduction/meson.build:    input: '_argkmin.pyx.tp',
sklearn/metrics/_pairwise_distances_reduction/meson.build:    output: '_radius_neighbors.pyx',
sklearn/metrics/_pairwise_distances_reduction/meson.build:    input: '_radius_neighbors.pyx.tp',
sklearn/metrics/_pairwise_distances_reduction/meson.build:  output: '_argkmin_classmode.pyx',
sklearn/metrics/_pairwise_distances_reduction/meson.build:  input: '_argkmin_classmode.pyx.tp',
sklearn/metrics/_pairwise_distances_reduction/meson.build:  output: '_radius_neighbors_classmode.pyx',
sklearn/metrics/_pairwise_distances_reduction/meson.build:  input: '_radius_neighbors_classmode.pyx.tp',
sklearn/metrics/meson.build:  output: '_dist_metrics.pyx',
sklearn/metrics/meson.build:  input: '_dist_metrics.pyx.tp',

The impact of this is that cython_args are not used for these extensions. Probably worth back-porting for 1.7.

@lesteve lesteve changed the title Fix sklearn utils meson BLD Add missing cython generator for a few extensions May 9, 2025
@lesteve lesteve added To backport PR merged in master that need a backport to a release branch defined based on the milestone. and removed To backport PR merged in master that need a backport to a release branch defined based on the milestone. labels May 9, 2025
@lesteve lesteve added this to the 1.7 milestone May 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5438136. Link to the linter CI: here

@lesteve lesteve added the Quick Review For PRs that are quick to review label May 9, 2025
@lesteve lesteve mentioned this pull request May 9, 2025
Open
@lorentzenchr lorentzenchr merged commit fec2fe6 into scikit-learn:main May 9, 2025
50 checks passed
@lesteve lesteve deleted the fix-sklearn-utils-meson branch May 12, 2025 13:22
@lesteve lesteve added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
module:cluster module:neighbors module:utils Quick Review For PRs that are quick to review To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@lesteve @thomasjpfan @lorentzenchr