Skip to content

DOC Improve documentation for macOS Homebrew libomp installation #31361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ParthS007
Copy link

@ParthS007 ParthS007 commented May 13, 2025

Reference Issues/PRs

Fixes #31359

What does this implement/fix? Explain your changes.

  • This PR helps users on all macOS architectures to correctly configure their environment for building scikit-learn with OpenMP support via Homebrew.

  • Tested the commands on my apple silicon processor (M2 Series).

Copy link

github-actions bot commented May 13, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 741f20a. Link to the linter CI: here

@ParthS007 ParthS007 force-pushed the doc_advanced_installation branch from 9af8da6 to 741f20a Compare May 13, 2025 10:30
@lesteve
Copy link
Member

lesteve commented May 13, 2025

Thanks for the PR!

I am guessing this documentation section is slightly outdated and setting the environment variables (CC, CXX, etc ...) is not needed anymore now that we use meson. It probably was needed when we use setuptools.

Could you try following the instructions without setting the environment variables (CC, `CXX, etc ...) and see whether that works for you?

There is also this in this section

For Apple Silicon M1 hardware, only the conda-forge method below is known to work at the time of writing

which maybe can be removed?

@ArturoAmorQ ArturoAmorQ changed the title 31359: add Documentation improvement for macOS Homebrew libomp installation DOC Improve documentation for macOS Homebrew libomp installation May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation improvement for macOS Homebrew libomp installation
2 participants