Avoid numpy array resize refcheck in svmlight format #31435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
reviewed
Jul 2, 2025
There was a problem hiding this comment.
Thanks for the PR @msimacek.
I'm not very familiar with this part of the code but a quick look showed that query is create as an array with a single value and never used/modified before this resize. So I think it's harmless to just allocate a new array, see my suggestion below. It should be safe for all python implementations, no ?
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
|
Yes, that seems even better, thanks. Should I squash the commits? |
no need, we do that when merging the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy.ndarray.resizedoes a reference check that there is only one reference to the array and so the resizing is safe. In this specific piece of code, the array has just been created and there is obviously only one reference. But this reference check doesn't work on PyPy and GraalPy, because they don't do reference counting the same way as CPython. I know that neither are officially supported, but they tend to mostly work and turning the check off could help those that want to try them.