Skip to content

Don't leak cache_directory from test_check_memory #31453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

Don't leak cache_directory from test_check_memory #31453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions sklearn/utils/tests/test_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1161,9 +1161,10 @@ class WrongDummyMemory:
pass


def test_check_memory():
memory = check_memory("cache_directory")
assert memory.location == "cache_directory"
def test_check_memory(tmp_path):
cache_directory = str(tmp_path / "cache_directory")
memory = check_memory(cache_directory)
assert memory.location == cache_directory

memory = check_memory(None)
assert memory.location is None
Expand Down