Skip to content

Conversation

adrinjalali
Copy link
Member

Suggested in #31408 to help third party developers.

Copy link

github-actions bot commented Jun 4, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: b24ca1e. Link to the linter CI: here

Copy link
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just a minor suggestion. Totally optional though.

Co-authored-by: Virgil Chan <virchan.math@gmail.com>
Copy link
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops~ Messed up the linting 😅

Co-authored-by: Virgil Chan <virchan.math@gmail.com>
@virchan virchan added Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one! labels Jun 11, 2025
@OmarManzoor OmarManzoor merged commit aa8b113 into scikit-learn:main Jun 12, 2025
44 checks passed
@adrinjalali adrinjalali deleted the doc/estimator_checks_generator branch June 12, 2025 07:45
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 15, 2025
…ator (scikit-learn#31480)

Co-authored-by: Virgil Chan <virchan.math@gmail.com>
@jeremiedbb jeremiedbb mentioned this pull request Jul 15, 2025
13 tasks
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025
…ator (scikit-learn#31480)

Co-authored-by: Virgil Chan <virchan.math@gmail.com>
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025
…ator (scikit-learn#31480)

Co-authored-by: Virgil Chan <virchan.math@gmail.com>
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025
…ator (scikit-learn#31480)

Co-authored-by: Virgil Chan <virchan.math@gmail.com>
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025
…ator (scikit-learn#31480)

Co-authored-by: Virgil Chan <virchan.math@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation module:utils Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants