-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
FEA Add DummyClassifier strategy that produces randomized probabilities #31488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for implementing this so quickly. I'd have done it myself but I appreciate you being so eager!
I left one non-blocking suggestion that I think will be ignored, since it seems to be not the trend in this project.
Great work! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I think we need to do two things in addition to a second review:
- do we want this feature?
- is there a better name for the strategy?
uniform-proba
doesn't really tell you what it is if you don't already know the answer. Could we have this behaviour as part ofuniform
(so no new name needed)? Ideas welcome
Thanks a lot for making the PR so quickly and without waiting for a 👍 / 👎. As so often the discussion about naming and whether we want to do this or not can take much longer than the actual implementation work. Patience please :D
I see it as a 'why not' feature. Its added functionality that doesn't hinder or affect existing functionality. Worst case, it goes unused but it shouldn't negatively affect anyone. Its a 2 way door decision.
Just let me know what to update it to. I named it what was suggested in the issue but have no preference on name |
@betatim thank you for your healthy skepticism :)
|
Co-authored-by: Tom McClintock <thmsmcclintock@gmail.com>
Reference Issues/PRs
Fixes #31462
What does this implement/fix? Explain your changes.
This PR adds a new strategy to DummyClassifier called "random_proba" that generates randomized probability distributions for classification tasks. This strategy can be used for benchmarking and testing purposes where completely random probabilistic outputs are desirable.