Skip to content

Doc add link plot robust vs empirical covariance examples #31511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

natmokval
Copy link
Contributor

Towards #30621

This PR adds a reference to the plot_robust_vs_empirical_covariance.py.

The plot_robust_vs_empirical_covariance example is already referenced in the User Guide. I added a link to make the example visible from the class MinCovDet documentation.

Copy link

github-actions bot commented Jun 9, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 594ec96. Link to the linter CI: here

Copy link
Member

@StefanieSenger StefanieSenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @natmokval, that's a really nice addition to the docs.

Can we merge that, @adrinjalali?

@StefanieSenger
Copy link
Member

@natmokval I think you're contributing with quality in mind and with care of the bigger picture. ❤️

If you would like to review PRs on this issue (or beyond), you're very welcome to do so. I'd personally be very happy.

Also, I've put a section "What comes next?" on the bottom of the issue, where I describe what could be the next steps to grow further into the scikit-learn ecosystem if you are interested. Especially, we've go the help wanted and moderate tag on issues and PRs that could be next steps to get into some more challenging areas.

Copying the section here for reference:

What comes next?

Co-authored-by: Stefanie Senger <91849487+StefanieSenger@users.noreply.github.com>
@natmokval
Copy link
Contributor Author

@natmokval I think you're contributing with quality in mind and with care of the bigger picture. ❤️

If you would like to review PRs on this issue (or beyond), you're very welcome to do so. I'd personally be very happy.

Also, I've put a section "What comes next?" on the bottom of the issue, where I describe what could be the next steps to grow further into the scikit-learn ecosystem if you are interested. Especially, we've go the help wanted and moderate tag on issues and PRs that could be next steps to get into some more challenging areas.

@StefanieSenger, thanks a lot for the kind words! I’m happy to dive deeper into scikit-learn and contribute more. I’ll check out the 'What comes next?' section and look for some more challenging areas to help with.

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, and happy to merge. In a separate PR, it would be nice to improve this example to the new notebook style with descriptions placed where relevant.

@adrinjalali adrinjalali merged commit 2e9b848 into scikit-learn:main Jun 18, 2025
36 checks passed
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 15, 2025
…rn#31511)

Co-authored-by: Stefanie Senger <91849487+StefanieSenger@users.noreply.github.com>
@jeremiedbb jeremiedbb mentioned this pull request Jul 15, 2025
13 tasks
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025
…rn#31511)

Co-authored-by: Stefanie Senger <91849487+StefanieSenger@users.noreply.github.com>
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025
…rn#31511)

Co-authored-by: Stefanie Senger <91849487+StefanieSenger@users.noreply.github.com>
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025
…rn#31511)

Co-authored-by: Stefanie Senger <91849487+StefanieSenger@users.noreply.github.com>
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025
…rn#31511)

Co-authored-by: Stefanie Senger <91849487+StefanieSenger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants