FIX Preserve y shape in TransformedTargetRegressor #31563
Merged
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the Pull Request @kryggird! If you have the time, could you take a look at the linter's complaints - it has instructions on how to install and run the linters as well which in 99.9% will automagically fix all the complaints. |
jeremiedbb
approved these changes
Jul 23, 2025
There was a problem hiding this comment.
Thanks for the PR @kryggird. I just moved the test you added into the TranformedTargetRegressor dedicated test file.
Please add a changelog entry. LGTM otherwise.
lucyleeow
pushed a commit
to lucyleeow/scikit-learn
that referenced
this pull request
Aug 22, 2025
…earn#31563) Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Sep 3, 2025
…earn#31563) Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes 26530.
What does this implement/fix? Explain your changes.
This PR uses the existing
self._training_dimto decide whether to squeezeybefore passing it the inner regressor inTransformedTargetRegressor.Any other comments?
I've also added a test in
test_metaestimators_metadata_routing.py.@betatim @glemaitre