-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
ENH Add array API for PolynomialFeatures #31580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ogrisel
merged 29 commits into
scikit-learn:main
from
OmarManzoor:array-api-poly-features
Jul 1, 2025
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
f6ff0ed
ENH Add array api support for PolynomialFeatures
OmarManzoor 63111d4
Add benchmark
OmarManzoor e9e1b16
Add benchmark
OmarManzoor 17fa68a
Remove benchmark file for testing
OmarManzoor a72f6e9
Add benchmark again for testing
OmarManzoor c58ad46
Remove benchmark file for testing
OmarManzoor 1518126
Add in documentation
OmarManzoor 2e96584
Add changelog
OmarManzoor a4f45b9
Merge branch 'main' into array-api-poly-features
OmarManzoor a9055f5
Refactor code in supported_float_dtypes
OmarManzoor e38629f
Merge branch 'main' into array-api-poly-features
OmarManzoor 7aaa83b
Update the supported float dtypes function
OmarManzoor 11906cc
Merge branch 'main' into array-api-poly-features
OmarManzoor 6620df5
Add device check in test
OmarManzoor 596e10c
Add array api tag
OmarManzoor d171ea1
Address PR suggestions
OmarManzoor e9fdca1
Minor updates
OmarManzoor f9f83b8
Merge branch 'main' into array-api-poly-features
OmarManzoor 66084a7
Minor fix
OmarManzoor dd328c5
Sync with main
OmarManzoor 5618b80
Add desc in test
OmarManzoor 95894a1
Address PR suggestions
OmarManzoor 789aa09
Assert dtype
OmarManzoor 8ec11ef
Add a test for supported_float_types
OmarManzoor 33a0be1
Merge branch 'main' into array-api-poly-features
OmarManzoor ef7e9ee
Improve the checking of dtypes rather than str in the test for suppor…
OmarManzoor 4804b43
Update sklearn/preprocessing/_polynomial.py
OmarManzoor ebbf4f8
Update sklearn/preprocessing/tests/test_polynomial.py
OmarManzoor 8e488f0
Update sklearn/preprocessing/tests/test_polynomial.py
OmarManzoor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
- :class:`preprocessing.PolynomialFeatures` now supports array API compatible inputs. | ||
By :user:`Omar Salman <OmarManzoor>` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.