-
-
Notifications
You must be signed in to change notification settings - Fork 26k
CI Move some pip_dependencies to conda_dependencies #31623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CI Move some pip_dependencies to conda_dependencies #31623
Conversation
This is a draft to be able to experiment. I checked all packages in pip_dependencies if the required version is available on the conda channel that is used in this CI setting. I was unsure and have not moved Other dependencies have not defined a version in our |
Okay, seems that the version change in |
I have moved
That shows that before version Edit: Nice they all passed. 🎉 Now it's only the Windows CI failing, and this is unrelated and coming from main. |
Do you know why we used |
@betatim: I didn't know this before, but @adrinjalali told me that's a maintanance task we do from time to time. It is necessary because the versions we need were not available (before) on the respective conda channel that is used for this job (some use conda-forge and other use conda defaults channel) - but now they might be and we prefer this. I also took notes while I checked everything. Let me share these, maybe it helps with reviewing: We have specific minimal version requirements in our
We do not have a version specified in
Whether I have checked the version from the main ("defaults") channel or the conda-forge channel depends on how the channel in the job was specified in |
Cool! Thanks for doing the "chopping wood and carrying water" on moving things from PyPI to conda. |
As far as I can tell all the moves make sense. I think we should wait for the CI to be working again and run it again. Maybe even using the |
"conda_dependencies": ["python", "ccache"], | ||
"pip_dependencies": ( | ||
remove_from(common_dependencies, ["python", "blas", "pip"]) | ||
"conda_dependencies": ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this build's goal (note the pip
in pylatest_pip_openblas_pandas
) is to install everything with pip
, and you don't want to move things to conda
dependencies here.
@@ -234,7 +231,15 @@ def remove_from(alist, to_remove): | |||
"folder": "build_tools/azure", | |||
"platform": "linux-64", | |||
"channels": ["defaults"], | |||
"conda_dependencies": ["python", "ccache"], | |||
"conda_dependencies": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here, the pip
inside the build name means we want to install all Python packages with pip.
# TODO: put cython, threadpoolctl and meson-python back to conda | ||
# dependencies when required version is available on the main channel | ||
"pip_dependencies": ["cython", "threadpoolctl", "meson-python", "meson"], | ||
"pip_dependencies": ["meson"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove meson
here because meson-python
depends on meson
and meson-python
is installed via the conda section.
This PR updates
update_environments_and_lock_files.py
to use conda for packages that were installed via pip but are now available on conda.