Skip to content

bump min dependencies anticipating next major release on 2025-11-01 #31656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GaetandeCast
Copy link
Contributor

@GaetandeCast GaetandeCast commented Jun 25, 2025

I will need the return_as=generator option of joblib 1.3 for #31279 . According to the maintenance guide, this version should be an acceptable dependency for the next major release. I updated the _min_dependencies according to the script linked in the maintainers guide. However I get the following error when trying to update the lock files:

RuntimeError: Command exited with non-zero exit code.
Exit code: 1
Command:
conda-lock lock --mamba --kind explicit --platform linux-64 --file build_tools/azure/pylatest_conda_forge_mkl_linux-64_environment.yml --filename-template build_tools/azure/pylatest_conda_forge_mkl_linux-64_conda.lock
stdout:

stderr:
Locking dependencies for ['linux-64']...
INFO:conda_lock.conda_solver:linux-64 using specs ['python', 'numpy', 'blas * mkl', 'scipy', 'cython', 'joblib', 'threadpoolctl', 'matplotlib', 'pandas', 'pyamg', 'pytest', 'pytest-xdist', 'pillow', 'pip', 'ninja', 'meson-python', 'pytest-cov', 'coverage', 'ccache', 'pytorch', 'pytorch-cpu', 'polars', 'pyarrow', 'array-api-strict', 'scipy-doctest']
Failed to parse json, Expecting value: line 1 column 1 (char 0)
Could not lock the environment for platform linux-64
    Command: ['/home/gaeta/miniforge3/condabin/mamba', 'create', '--prefix', '/tmp/tmp1plne90a/prefix', '--dry-run', '--json', '--override-channels', '--channel', 'conda-forge', '--channel', 'file:///tmp/tmpohnhg00y', 'python', 'numpy', 'blas * mkl', 'scipy', 'cython', 'joblib', 'threadpoolctl', 'matplotlib', 'pandas', 'pyamg', 'pytest', 'pytest-xdist', 'pillow', 'pip', 'ninja', 'meson-python', 'pytest-cov', 'coverage', 'ccache', 'pytorch', 'pytorch-cpu', 'polars', 'pyarrow', 'array-api-strict', 'scipy-doctest']

Cc: @ogrisel @glemaitre

@glemaitre glemaitre self-requested a review June 25, 2025 09:23
Copy link

github-actions bot commented Jun 25, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 6901cef. Link to the linter CI: here

@glemaitre
Copy link
Member

I updated the lock files locally and push. I did not get the failures.

@virchan virchan added the dependencies Pull requests that update a dependency file label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants