-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
DOC: Remove FIXME tags from glossary #31677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Remove FIXME tags from glossary #31677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good overall, thanks @ShauryaDusht.
Only the one Fixme doesn't render correctly (see my comment).
There is a draft PR addressing the same issue (#31674), that seems to be more about fixing a ModuleNotFoundError
. I'm not sure if this was a double effort or if these two can combine each other. In general, if someone has already opened a PR, we encourage contributors to wait a few weeks before taking over a task.
Thanks @StefanieSenger for the review and for pointing out the rendering issue.
I simply saw the open issue and thought the linked PR was closed. I didn’t notice it was still in draft. So I aimed to resolve those tags.
I wasn’t aware of the guideline to wait before taking over recently worked-on issues. I’ll definitely keep that in mind moving forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @ShauryaDusht
Reference Issues/PRs
Fixes #31628
What does this implement/fix? Explain your changes.
This pull request removes four
FIXME
tags from the Glossary page in the documentation. These tags are not intended for end users and should not appear in user-facing content.Where relevant:
FIXME
notes into comments to retain context for future contributors.This helps keep the glossary clean, professional, and user-friendly.
Any other comments?
Let me know if any additional changes are needed.