Skip to content

DOC Make references to scipy modules/functions links in pairwise.py #31694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

DOC Make references to scipy modules/functions links in pairwise.py #31694

merged 2 commits into from
Jul 3, 2025

Conversation

lucyleeow
Copy link
Member

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

@lucyleeow lucyleeow changed the title DOC Make references to scipy modules/functions links DOC Make references to scipy modules/functions links in pairwise.py Jul 3, 2025
@lucyleeow lucyleeow added the Quick Review For PRs that are quick to review label Jul 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: c6146ef. Link to the linter CI: here

@lucyleeow
Copy link
Member Author

I've checked the rendered docs to make sure the links are good.

virchan
virchan approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and the rendered docs look great! Thanks @lucyleeow!

@virchan virchan added the Waiting for Second Reviewer First reviewer is done, need a second one! label Jul 3, 2025
OmarManzoor
OmarManzoor approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @lucyleeow

@OmarManzoor OmarManzoor merged commit 7446009 into scikit-learn:main Jul 3, 2025
40 checks passed
@lucyleeow lucyleeow deleted the doc_pairwise branch July 3, 2025 11:22
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 15, 2025
@lucyleeow @jeremiedbb
DOC Make references to scipy modules/functions links in pairwise.py (…
c084f09 
…scikit-learn#31694)
@jeremiedbb jeremiedbb mentioned this pull request Jul 15, 2025
Merged
13 tasks
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025
@lucyleeow @jeremiedbb
DOC Make references to scipy modules/functions links in pairwise.py (…
f1043cd 
…scikit-learn#31694)
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025
@lucyleeow @jeremiedbb
DOC Make references to scipy modules/functions links in pairwise.py (…
2536c70 
…scikit-learn#31694)
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025
@lucyleeow @jeremiedbb
DOC Make references to scipy modules/functions links in pairwise.py (…
0baaca3 
…scikit-learn#31694)
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025
@lucyleeow @jeremiedbb
DOC Make references to scipy modules/functions links in pairwise.py (…
15d93d1 
…scikit-learn#31694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarManzoor OmarManzoor OmarManzoor approved these changes

+1 more reviewer

@virchan virchan virchan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Documentation module:metrics Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucyleeow @OmarManzoor @virchan