Skip to content

Conversation

scikit-learn-bot
Copy link
Contributor

Update lock files.

Note

If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.

Copy link

github-actions bot commented Jul 7, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5d1a36d. Link to the linter CI: here

@jeremiedbb
Copy link
Member

There's 1 test failing on the ARM job because of numerical precision: the test sets a rtol=1e-12 and the results are barely over this tol. Looking at the lock file diff, my guess would be that it comes from the upgrade of OpenBLAS. That being said, 1e-12 is a very low rtol that is way beyond our usual expectations in terms of tolerance. We're usually happy with 1e-7. So I think we can just lower the expectation of this test to match what we usually expect in sklearn.

@ogrisel ogrisel merged commit 5e7e7bd into scikit-learn:main Jul 7, 2025
39 of 40 checks passed
jeremiedbb added a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 15, 2025
Co-authored-by: Lock file bot <noreply@github.com>
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
@jeremiedbb jeremiedbb mentioned this pull request Jul 15, 2025
13 tasks
jeremiedbb added a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025
Co-authored-by: Lock file bot <noreply@github.com>
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
jeremiedbb added a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025
Co-authored-by: Lock file bot <noreply@github.com>
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
jeremiedbb added a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025
Co-authored-by: Lock file bot <noreply@github.com>
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
jeremiedbb added a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025
Co-authored-by: Lock file bot <noreply@github.com>
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants